Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 - fregrid_acc: cleanup and funcion get_cell_minmaxavg_latlons_acc #290

Closed
wants to merge 35 commits into from

Conversation

mlee03
Copy link

@mlee03 mlee03 commented May 17, 2024

In this PR,

  1. Files fregrid_utils_acc.c/h have been changed to interp_acc.c/h. These files will contain all miscellaneous functions used in conserve_interp.c and bilinear_interp.c.
  2. The function names in the directories fregrid_acc and libfrencutils_acc have been changed to end with prefix _acc.
  3. File parameters.h has been created and all macros used in fregrid_acc are/will be defined in this file.
  4. A new struct called Cell has been introduced. This struct will be used to store grid cell information such as the cell vertices and will be used in create_xgrid functions.
  5. All non-create_xgrid functions have been removed from create_xgrid_acc.c These functions have either been removed or relocated to create_xgrid_utils_acc.c/h and general_utils_acc.c/h.
  6. Files general_utils_acc.c/h have been created. These files duplicate functions in libfrenctutils/mosaic_utils.c/h. These functions will be cleaned up and if possible, optimized, to make them actually user-friendly and understandable.
  7. New functions called get_cell_minmaxavg_latlons_acc and get_cell_vertices_acc have been created. These functions are used to populate the Cell struct. Functional unit test for get_cell_minmaxavg_latlons_acc has been added.

@mlee03 mlee03 changed the title fregrid_acc cleanup and funcion get_cell_minmaxavg_latlons_acc 4 - fregrid_acc cleanup and funcion get_cell_minmaxavg_latlons_acc May 17, 2024
@mlee03 mlee03 requested review from bensonr and rem1776 May 17, 2024 18:02
@mlee03 mlee03 changed the title 4 - fregrid_acc cleanup and funcion get_cell_minmaxavg_latlons_acc 4 - fregrid_acc: cleanup and funcion get_cell_minmaxavg_latlons_acc May 24, 2024
@mlee03
Copy link
Author

mlee03 commented Jun 13, 2024

closing, a larger PR will contain this PR.

@mlee03 mlee03 closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant