-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4 - fregrid_acc: cleanup and funcion get_cell_minmaxavg_latlons_acc #290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlee03
changed the title
fregrid_acc cleanup and funcion get_cell_minmaxavg_latlons_acc
4 - fregrid_acc cleanup and funcion get_cell_minmaxavg_latlons_acc
May 17, 2024
mlee03
changed the title
4 - fregrid_acc cleanup and funcion get_cell_minmaxavg_latlons_acc
4 - fregrid_acc: cleanup and funcion get_cell_minmaxavg_latlons_acc
May 24, 2024
closing, a larger PR will contain this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
fregrid_utils_acc.c/h
have been changed tointerp_acc.c/h
. These files will contain all miscellaneous functions used in conserve_interp.c and bilinear_interp.c._acc
.parameters.h
has been created and all macros used in fregrid_acc are/will be defined in this file.Cell
has been introduced. This struct will be used to store grid cell information such as the cell vertices and will be used in create_xgrid functions.create_xgrid_acc.c
These functions have either been removed or relocated tocreate_xgrid_utils_acc.c/h
andgeneral_utils_acc.c/h
.general_utils_acc.c/h
have been created. These files duplicate functions in libfrenctutils/mosaic_utils.c/h. These functions will be cleaned up and if possible, optimized, to make them actually user-friendly and understandable.get_cell_minmaxavg_latlons_acc
andget_cell_vertices_acc
have been created. These functions are used to populate the Cell struct. Functional unit test forget_cell_minmaxavg_latlons_acc
has been added.