Additional option "on_grid" for make_topog #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction it prevents changes on topography due to regridding
|
@ThomasNeumann2, I am curious to know the use-case for this change. Could you provide an exmaple of where and how this mod is used? Thanks. |
mlee03
reviewed
May 24, 2024
mlee03
approved these changes
May 24, 2024
nikizadehgfdl
approved these changes
May 24, 2024
bensonr
approved these changes
May 24, 2024
rem1776
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced option "on_grid" which skips the regridding function. Using make_topog , we experienced changes in the topography even if the topography is on the target grid and "--dont_adjust_topo" is active. The reason seems to be that the topography is always passed through the regridding.