5 - fregrid_acc: rename variables, get_bounding_indices, get_input_skip_cells #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 11, 2024 19:02
…und_nxgrid_order1
added 25 commits
May 16, 2024 17:41
…und_nxgrid_order1
…und_nxgrid_order1
|
closing, a larger PR will contain this PR. |
|
Closing this based on the last comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
Many of the variables were renamed to better reflect their usage. Of these variables,
interpwas renamed toxgridto better indicate that the struct contains exchange grid information.Function
get_bounding_indiceswas defined to compute the lower and top input cell latitudinal indices. These indices are the bounding points of the overlapping grid region.Function
get_skip_cellswas defined to set up what was formerly known as the "mask". The "mask" is used to skip input cells in exchange grid creation and is not used in fregrid_acc (but it's used in FMS horiz_interp?)