Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI image #306

Merged
merged 8 commits into from
Sep 3, 2024
Merged

Update CI image #306

merged 8 commits into from
Sep 3, 2024

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Jul 31, 2024

updates the ci image to a rocky 9 image with spack installed dependencies. The dockerfile is here.

@rem1776 rem1776 requested a review from ceblanton August 1, 2024 14:32
Copy link
Contributor

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I confess I never completely understood how the fre-nctools-base image was stored and retrieved, and it looks like you're moving to this reasonably-looking approach:

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

Is the ghcr.io/noaa-gfdl image available now, or should we wait?

@rem1776
Copy link
Contributor Author

rem1776 commented Sep 3, 2024

Looks fine, but I confess I never completely understood how the fre-nctools-base image was stored and retrieved, and it looks like you're moving to this reasonably-looking approach:

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry

Is the ghcr.io/noaa-gfdl image available now, or should we wait?

Yeah this is basically just moving from dockerhub to github and also updating to use the latest dependencies + gcc. The registry switch up was because there was a whole thing with dockerhub cancelling all free organization accounts (which we have), but i think they went back on it since. It doesn't make much of a difference to be honest, all registries generally work the same at the end of the day.

The image is ready now, it pulled the new image when it ran the CI for this pull request.

@ceblanton
Copy link
Contributor

Thank you!

@ceblanton ceblanton merged commit e92dc37 into NOAA-GFDL:main Sep 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants