Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del bounds attr from coord in drop_attributes() #733

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

jtmims
Copy link
Collaborator

@jtmims jtmims commented Jan 17, 2025

Description
The bounds attr was still found in the time coord after the bounds data was dropped. This PR makes sure this attribute is deleted from the coord. It also changes the conditional of an If statement to make sure we are only reconciling the variable asked by the function call.

Associated issue #730

Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.12 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

@wrongkindofdoctor wrongkindofdoctor merged commit 3895cc9 into NOAA-GFDL:main Jan 17, 2025
4 checks passed
@wrongkindofdoctor wrongkindofdoctor self-assigned this Jan 17, 2025
@wrongkindofdoctor wrongkindofdoctor added bug Something isn't working framework Issue pertains to the framework code labels Jan 17, 2025
@jtmims jtmims mentioned this pull request Jan 17, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework Issue pertains to the framework code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants