Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*+Add ePBL bottom boundary layer mixing option #717

Draft
wants to merge 2 commits into
base: dev/gfdl
Choose a base branch
from
Draft

*+Add ePBL bottom boundary layer mixing option #717

wants to merge 2 commits into from

Commits on Sep 18, 2024

  1. *Fix a bug when EPBL_ORIGINAL_PE_CALC is false 

      Corrected a bug that causes ePBL column to set the wrong variable and then use
an uninitialized variable when EPBL_ORIGINAL_PE_CALC is set to false.  This bug
was present when the EPBL_ORIGINAL_PE_CALC was first added on Sept. 30, 2016,
but it was not detected because only the default case with EPBL_ORIGINAL_PE_CALC
= True appears to being used or tested.  Any runs that used this code with
debugging compile options would have trapped it immediately.  This will change
answers when EPBL_ORIGINAL_PE_CALC is false.
    @Hallberg-NOAA
    Hallberg-NOAA committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    08ecd26 View commit details
    Browse the repository at this point in the history

  2. +(*)Add ePBL bottom boundary mixing option 

      Add the option to do energetically consistent bottom boundary layer mixing with
the new routine ePBL_BBL_column.  ePBL_BBL_column is closely based on the
surface-focused ePBL mixing in ePBL_column, but without adding convective
instability driven mixing or mean-TKE driven mixing to avoid possible
double-counting.  This new option is enabled by setting the new runtime parameter
EPBL_BBL_EFFIC to be positive.

  If both EPBL_BBL_EFFIC and BBL_EFFIC are set to positive values, there is a
risk of double-counting, but this case is not being trapped for now.

  Within ePBL_column, the hp_a variable was converted from a scalar into a 1-d
array to emphasize where these variables are located and to bring ePBL_column
closer to what would be required if the new diffusivities were being applied on
top of diffusivities from other processes, as is the case in ePBL_BBL_column.
Several comments in find_PE_change and ePBL_column were corrected.  Two
allocatable three-dimensional diagnostic arrays that had been in the
energetic_PBL control structure were converted into local arrays to reduce the
dedicated memory requirements when these diagnostics are enabled.

  The changes include the addition of a new mandatory vertvisc_type argument to
the publicly visible routine energetic_PBL.

  When this new ePBL bottom boundary layer mixing option is enabled, there are
several new diagnostics available that are related to bottom boundary layer
mixing.  Several new checksum calls were also added with this new option when
DEBUG = True. The MOM_parameter_doc files are altered by the addition of two new
runtime parameters, and by the correction of several spelling errors in the
descriptions of other ePBL parameters.  By default, all answers are bitwise
identical.
    @Hallberg-NOAA
    Hallberg-NOAA committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    60b636b View commit details
    Browse the repository at this point in the history