-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanups in dace orchestration #87
Cleanups in dace orchestration #87
Conversation
Readability improvements in dace orchestration including - early returns - spelling out variable names - fixing typos
18db0bf
to
9efb5f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on select changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just one change around program
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the logic.
Description
Readability improvements in dace orchestration including
This is part of a tech debt / cleanup series of PRs going into NDSL, gt4py, and dace.
How Has This Been Tested?
Existing tests in CI will ensure nothing serious is broken by these changes.
Checklist:
I guess so ... not sure though. How do people usually check?