Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups in dace orchestration #87

Merged

Conversation

romanc
Copy link
Collaborator

@romanc romanc commented Dec 4, 2024

Description

Readability improvements in dace orchestration including

  • early returns
  • spelling out variable names
  • fixing typos

This is part of a tech debt / cleanup series of PRs going into NDSL, gt4py, and dace.

How Has This Been Tested?

Existing tests in CI will ensure nothing serious is broken by these changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas: N/A
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
    I guess so ... not sure though. How do people usually check?
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included: N/A

Readability improvements in dace orchestration including

- early returns
- spelling out variable names
- fixing typos
@romanc romanc force-pushed the romanc/cleanups-orchestartion branch from 18db0bf to 9efb5f4 Compare December 4, 2024 09:21
Copy link
Collaborator Author

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on select changes

ndsl/dsl/dace/orchestration.py Show resolved Hide resolved
ndsl/dsl/dace/orchestration.py Show resolved Hide resolved
ndsl/dsl/dace/orchestration.py Show resolved Hide resolved
ndsl/dsl/dace/orchestration.py Show resolved Hide resolved
@romanc romanc marked this pull request as ready for review December 4, 2024 09:30
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one change around program

ndsl/dsl/dace/orchestration.py Show resolved Hide resolved
ndsl/dsl/dace/orchestration.py Show resolved Hide resolved
ndsl/dsl/dace/orchestration.py Outdated Show resolved Hide resolved
ndsl/dsl/dace/orchestration.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the logic.

@FlorianDeconinck FlorianDeconinck merged commit 60a8f59 into NOAA-GFDL:develop Dec 5, 2024
5 checks passed
@romanc romanc deleted the romanc/cleanups-orchestartion branch December 6, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants