Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracer rework (Part 1): allow N tracers advection #37

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

FlorianDeconinck
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck commented Dec 16, 2024

As explained in NOAA-GFDL/pace#100, the tracer in dynamics is a fixed-length series of 9 tracers. We propose here to solve the first step of a global rework by allowing N tracers to be advected.

⚠️ This PR will trigger failure in Pace and requires a sync PR in NDSL (TBPR) ⚠️

The solution merely generalize the previous tracer system into a class which carries a dictionary of Quantities. An exclude_tracers list is now present in Tracer Advection and Remapping to cover the FV3GFS dataset which (oddly) excludes clouds from the schemes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming

WIP

  • Fix orchestration
  • PR in NDSL
  • Fix GEOS_WRAPPER
  • FIx initialize TC
  • Fix initialize Baroclinic
  • Connect back to Pace

@FlorianDeconinck FlorianDeconinck changed the title Ttracer rework (Part 1): allow N tracers advection Tracer rework (Part 1): allow N tracers advection Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant