Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shieldclock crash in dycore_only #40

Closed
wants to merge 2 commits into from

Conversation

JosephMouallem
Copy link
Contributor

shieldClock timer starts in update_atmos_pre_radiation and ends in update_atmos_physics.
This causes a crash when compiling shield and running with dycore_only since update_atmos_physics is not called in update_atmos_radiation_physics, mpp_clock_begin is called again before calling mpp_clock_end.

In this commit both mpp_clock_begin and mpp_clock_end are moved to update_atmos_radiation_physics.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

@JosephMouallem
Copy link
Contributor Author

@bensonr

@laurenchilutti
Copy link
Contributor

Merging #34 would fix this bug. So we can probable close this and merge #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants