Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null model yaml example #185

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Sep 16, 2024

Describe your changes

Adds yamls to compile the null model that we use to test the coupler. The changes are made on top of #168 so this is a draft until that goes in.

Issue ticket number and link (if applicable)

Fixes #179

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

@singhd789
Copy link
Collaborator

This uses changes used in this PR (#168) that was merged this morning.

You can get pull the most recent updates and just have the null_example pushed here!

@rem1776 rem1776 marked this pull request as ready for review September 30, 2024 19:03
container_addlibs:
baremetal_linkerflags:
src:
- component: "FMS"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarification, why are some components _null and some not? Is it supposed to be like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just cause FMS and the coupler aren't specific to the null_model, everything else has the null cause they don't do anything.

Copy link
Collaborator

@singhd789 singhd789 Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about ice_param? Should it have _null? Also, since FMS and the coupler aren't null, the model will compile with these then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think theres no null alternative for ice_param so the real version is required.

Yeah the whole point of the null model is to compile the coupler program without real components, since its the main program thats pulling all these other modules in. It still needs FMS cause it tests basic things every model does like reading certain input files and mpi stuff.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, thanks!

# compile information
- &branch "main"
- &INTEL "intel-classic"
- &FMSincludes "-IFMS/include"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any momIncludes needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No i don't think so. I'm not sure how different ocean_null is from mom but it didn't seem to need includes when i compiled this.

@ilaflott ilaflott merged commit eecdb44 into NOAA-GFDL:main Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop null model yaml and compile yaml for null model
3 participants