Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

224.fre make compile test #295

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

224.fre make compile test #295

wants to merge 20 commits into from

Conversation

singhd789
Copy link
Collaborator

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

@singhd789
#224 Add fre make create-compile pytests
5b0eb45
@singhd789
#224 Fix test so it uses null_example instead of AM5
2ca2234
@singhd789
#224 Remove AM5 from fre/make/tests
e9d6bee
@singhd789
#224 Get rid of AM5
419c37a
@singhd789
#224 Change sys.exit to click.echo statement
3095918
@singhd789
#225 Remove more "am5" usages
6680036
@singhd789
#224 Add output files from fre make tests
42d449b
@singhd789
#224 Remove re-setting HOME; use ci.gnu platform for tests
b7047e7
@singhd789
#224 Merge branch 'main' of github.com:NOAA-GFDL/fre-cli into 224.fr…
e4de828 
…e-make-compile-test
@singhd789
#224 Clean script/move echo statements
60b7ce6
@singhd789
#224 Add more compile failure tests
61e889c
@singhd789
#224 Add tests in compile tool test
5c99b29
@singhd789
#224 Merge branch 'main' of github.com:NOAA-GFDL/fre-cli into 224.fr…
21bb5d2 
…e-make-compile-test
@singhd789
#224 Remove unecessary print statements
62d1c17
@singhd789
#224 Fix fail case
6945dbb
@singhd789
#224 Fix assertion for multi-target output paths
50c0e9e
@singhd789
#224 Fix MULTI_TARGET variable reference
c94f5d9
@singhd789
#224 See where test is running
71be40a
@singhd789
#224 Move os.environ to inside tests
d99dddb
@singhd789 singhd789 requested a review from rem1776 December 26, 2024 17:43
@singhd789 singhd789 marked this pull request as ready for review December 26, 2024 17:43
kiihne-noaa
kiihne-noaa reviewed Dec 26, 2024
View reviewed changes
Copy link
Contributor

@kiihne-noaa kiihne-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! We discussed a number of these changes last week.

@singhd789 singhd789 requested a review from Ciheim December 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiihne-noaa kiihne-noaa kiihne-noaa left review comments

@rem1776 rem1776 Awaiting requested review from rem1776

@Ciheim Ciheim Awaiting requested review from Ciheim

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@singhd789 @kiihne-noaa