Pressure masking netcdf modifying tool #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a neat self-contained tool that is useful to for FRE workflows, but it needs more documentation, tests, and it's not working perfectly yet in comparison to the Bronx refinediag script. |
|
@ceblanton I'm going to go in and change the argparse to click while I review this |
chanwilson
requested changes
Mar 5, 2024
|
I'm also not overjoyed about the qty of changes required when adding sub-commands, I have a couple thoughts on how to make that better.... but not for this PR. |
|
This really needs a single pytest. |
bcc2761
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.