Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in QGIS based routine: tnx nexus is now in the geopackage and… #700

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

JurgenZach-NOAA
Copy link
Contributor

… forcing files

[Short description explaining the high-level reason for the pull request]

Additions

Removals

Changes

Prior to this commit, the tnx (terminal nexus) was missing, due to a bug in the QGIS based subsetting routine. The latter is corrected now, and the subset geopackage and forcing files were regenerated.

Testing

  1. Running Lower Colorado test case per instructions to verify proper execution. More fundamentally, look for tnx in the nexus vector layer of the geopackage.

Screenshots

image

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@JurgenZach-NOAA
Copy link
Contributor Author

Just an added comment: the actual subsetting routine is NOT part of this commit - its updated version can be found in a separate pull request in the t-route-tools repository.

@shorvath-noaa shorvath-noaa merged commit 0663fc7 into NOAA-OWP:master Nov 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants