Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writing nc file with different frequency (Update for #697) #708

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

AminTorabi-NOAA
Copy link
Contributor

A code added in LowerColorado_TX_v4 for running the bmi. It uses the "test_AnA_V4_HYFeature" yaml file.

Additions

  • make sure in test_AnA_V4_HYFeature.yaml file lastobs_output_folder commented out ( : #lastobs/)
  • The flowveldepth functions added to model_DAforcing file.
  • LOG also added instead of print (using log_level_set function)
  • waterbodies_df was giving error in reconstructing the dataframe that some column are missing. I add the 3 columns of 'lon', 'lat', 'crs' and after reconstructing the dataframe drped them.
  • flowveldepth function added
  • run_with_BMI.py file is updated on the base_path address to be independent of my directory.
  • output_parameters added in the troute_model file
  • Config file edited in a way that a validator checks if 'nts' is a valid value

Removals

Changes

Testing

  1. Tested on LowerColorado_TX_v4 and it works.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Copy link
Contributor

@shorvath-noaa shorvath-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the column names in the output files are still incorrect. When I have the settings to start_datetime: 2023-04-02_00:00, .csv output, 1 per hour, and 30 minute internal frequency, the first file, 202304020000.flowveldepth.csv, has these column headings:
,q_202304020000,v_202304020000,d_202304020000,ndg_202304020000,q_202304020030,v_202304020030,d_202304020030,ndg_202304020030

This says the first value returned is at t0 which I don't think is correct. It should be t0 plus 30 minutes, right?

Could you also add a column name for the first column, maybe feature_id?

result = nts * dt / (internal_freq * 60)
if not result.is_integer():
raise ValueError("UPDATE nts. nts*dt/(stream_output_internal_frequency*60) must be an integer.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the error message a little clearer here? Using plain english rather than variable/equations would be nice.

shorvath-noaa
shorvath-noaa previously approved these changes Dec 4, 2023
@AminTorabi-NOAA AminTorabi-NOAA merged commit 7ebb747 into NOAA-OWP:master Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants