Feat/week 뷰모델 분리 - compose #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eonji-sw
reviewed
May 26, 2024
| @Serializable | ||
| data class ResponseFriendDto( | ||
| @SerialName("data") | ||
| val `data`: List<FriendData>, |
| import retrofit2.http.POST | ||
|
|
||
| interface AuthService { | ||
| @POST("member/join") |
| interface FriendService { | ||
| @GET("users") | ||
| fun getFriend( | ||
| @Query("page") page: Int |
| interface UserService { | ||
| @GET("member/info") | ||
| fun getUser( | ||
| @Header("memberId") userId: String? |
| phone = "010-5678-1234" | ||
| ) | ||
| ) | ||
| val userData: MutableState<ResponseUserDto.UserData?> = mutableStateOf(null) |
There was a problem hiding this comment.
mutableStateOf 잘 적용하였네요! 그런데 UserData는 왜 nullable 하나욤??
| @@ -0,0 +1,7 @@ | |||
| package com.sopt.now.compose.ui.login | |||
|
|
|||
| data class LoginState( | |||
There was a problem hiding this comment.
UiState에 대해서도 학습해보고 적용하면 좋을 것 같아요!
Comment on lines
+14
to
+15
| private val _userData = MutableLiveData<ResponseUserDto.UserData>() | ||
| val userData: LiveData<ResponseUserDto.UserData> = _userData |
There was a problem hiding this comment.
이 부분도 homeViewModel 처럼 수정하면 좋을 것 같아요
|
|
||
| Log.d("MyPageViewModel", "User data: ${_userData.value}") | ||
| } else { | ||
| Log.d("MyPageViewModel", "Failed to load user data: $userId") |
There was a problem hiding this comment.
여기에도 userId보다는 error message를 띄워주는게 디버깅하기 더 좋을 것 같아요!
Comment on lines
+187
to
+194
| val signUpRequest = RequestSignUpDto( | ||
| authenticationId = userId, | ||
| password = userPassword, | ||
| nickname = userNickname, | ||
| phone = userPhone | ||
| ) | ||
|
|
||
| val user = User(userId, userPassword, userNickname, userPhone) | ||
| val intent = Intent(context, LoginActivity::class.java) | ||
| intent.putExtra("user", user) | ||
| viewModel.signUp(signUpRequest) |
There was a problem hiding this comment.
viewModel.signUp(RequestSignUpDto(
authenticationId = userId,
password = userPassword,
nickname = userNickname,
phone = userPhone
))
| response: Response<ResponseSignUpDto>, | ||
| ) { | ||
| if (response.isSuccessful) { | ||
| val data: ResponseSignUpDto? = response.body() |
2 tasks
Hyobeen-Park
approved these changes
May 27, 2024
| items(friendList) { | ||
| FriendProfileItem(it) | ||
| items(friendList) { friend -> | ||
| FriendProfileItem(friend) |
| class SignUpViewModel : ViewModel() { | ||
| private val authService by lazy { ServicePool.authService } | ||
|
|
||
| val liveData = MutableLiveData<SignUpState>() |
There was a problem hiding this comment.
이거는 get() 써서 _liveData 이렇게 처리 안해줘도 괜찮나요???(궁금해서 여쭤보는거에용ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Issues
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷 Screenshot
💬To Reviewers
week04_compose에서 브랜치 파서 했습니다!
시험 끝나고 꼭꼭 할게요 ㅠㅠ