-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/week06-xml-advanced #32
base: develop-xml
Are you sure you want to change the base?
Changes from all commits
81cdc3b
f044f7f
5252ae3
151a121
81b98d3
e552454
ef84eae
15ed283
8571afe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,15 +17,13 @@ class FollowerFragment : Fragment() { | |
private lateinit var followerAdapter: FollowerAdapter | ||
|
||
override fun onCreateView( | ||
inflater: LayoutInflater, | ||
container: ViewGroup?, | ||
savedInstanceState: Bundle?, | ||
): View { | ||
inflater: LayoutInflater, container: ViewGroup?, | ||
savedInstanceState: Bundle? | ||
): View? { | ||
_binding = FragmentFollowerBinding.inflate(inflater, container, false) | ||
return binding.root | ||
return _binding?.root | ||
} | ||
|
||
|
||
override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||
super.onViewCreated(view, savedInstanceState) | ||
|
||
|
@@ -47,7 +45,7 @@ class FollowerFragment : Fragment() { | |
|
||
override fun onDestroyView() { | ||
super.onDestroyView() | ||
_binding?.rvFollower?.adapter = null | ||
_binding = null | ||
Comment on lines
47
to
49
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. followerAdapter 를 메모리 해제처리 해줘야합니다 |
||
binding.rvFollower.adapter = null | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -1,7 +1,9 @@ | ||||||||||
package com.sopt.now.ui.search | ||||||||||
|
||||||||||
import android.os.Bundle | ||||||||||
import android.view.LayoutInflater | ||||||||||
import android.view.View | ||||||||||
import android.view.ViewGroup | ||||||||||
import androidx.fragment.app.Fragment | ||||||||||
import androidx.fragment.app.viewModels | ||||||||||
import com.sopt.now.databinding.FragmentSearchBinding | ||||||||||
|
@@ -14,6 +16,14 @@ class SearchFragment : Fragment() { | |||||||||
private val searchViewModel: SearchViewModel by viewModels() | ||||||||||
private lateinit var repoAdapter: RepoAdapter | ||||||||||
|
||||||||||
override fun onCreateView( | ||||||||||
inflater: LayoutInflater, container: ViewGroup?, | ||||||||||
savedInstanceState: Bundle? | ||||||||||
): View? { | ||||||||||
_binding = FragmentSearchBinding.inflate(inflater, container, false) | ||||||||||
return _binding?.root | ||||||||||
} | ||||||||||
Comment on lines
+24
to
+25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||||||||||
super.onViewCreated(view, savedInstanceState) | ||||||||||
setupAdapters() | ||||||||||
|
@@ -34,7 +44,7 @@ class SearchFragment : Fragment() { | |||||||||
|
||||||||||
override fun onDestroyView() { | ||||||||||
super.onDestroyView() | ||||||||||
_binding?.rvRepo?.adapter = null | ||||||||||
_binding = null | ||||||||||
Comment on lines
46
to
48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 여기도 _binding?.rvRepo?.adapter = null는 의미 없습니당 |
||||||||||
binding.rvRepo.adapter = null | ||||||||||
} | ||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
왜 바꾸신 것일까여?