[Feature/#38] 클린 적용 #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chattymin
reviewed
Jun 27, 2024
| @@ -47,7 +47,7 @@ class MainActivity : ComponentActivity() { | |||
| @Composable | |||
| fun MainContent( | |||
| navController: NavHostController, | |||
| userRepository: UserRepository, | |||
| userRepository: AuthRepository, | |||
There was a problem hiding this comment.
왜 레포지토리를 여기서 주입해주는걸까요??
사용하는 곳이 viewModel이니 거기서 주입해주면 좋을 것 같아요
|
|
||
| @Composable | ||
| fun SignupScreen(navController: NavController) { | ||
| val viewModel: SignupViewModel = hiltViewModel() | ||
| fun SignupRoute(navController: NavController, viewModel: SignupViewModel = hiltViewModel()) { |
There was a problem hiding this comment.
저는 navController를 넘기는 방법을 선호하지는 않습니다. 하지만 한끼 코드에 제가 다른 방법을 적용시켜뒀으니 그 부분을 보고 공부한다면 좋을 것 같네요~
| var phone by remember { mutableStateOf("") } | ||
|
|
||
| val authState by viewModel.signupStatus.observeAsState() | ||
| val signUpState by viewModel.signUpState.collectAsState() |
There was a problem hiding this comment.
collectAsStateWithlifecycle이라는 친구가 있어요. 알아보고 적용하면 좋을 것 같네요
There was a problem hiding this comment.
collectAsStateWithlifecycle를 사용하면 StateFlow를 Lifecycle 인식하며 데이터를 가져올 수 있어서 더 좋은 코드가 될 수 있을 거 같습니다! 감사합니다~
Comment on lines
57
to
70
| LaunchedEffect(viewModel.sideEffect) { | ||
| viewModel.sideEffect.collectLatest { sideEffect -> | ||
| when (sideEffect) { | ||
| is SignupViewModel.SignupSideEffect.ShowError -> { | ||
| snackbarHostState.showSnackbar( | ||
| message = sideEffect.message, | ||
| duration = SnackbarDuration.Short | ||
| ) | ||
| } | ||
|
|
||
| SignupViewModel.SignupSideEffect.NavigateToMain -> { | ||
| navController.navigate("login") { | ||
| popUpTo("signup") { inclusive = true } | ||
| } |
| import kotlinx.coroutines.launch | ||
| import retrofit2.Response | ||
| import javax.inject.Inject | ||
|
|
||
| @HiltViewModel | ||
| class SignupViewModel @Inject constructor( | ||
| private val userRepository: UserRepository, | ||
| private val authRepository: AuthRepository, |
There was a problem hiding this comment.
아 여기엔 해뒀네요
수정 과정에서 윗 부분 수정이 안된거 같군요~
Comment on lines
102
to
105
| sealed class SignupSideEffect { | ||
| data class ShowError(val message: String) : SignupSideEffect() | ||
| data object NavigateToMain : SignupSideEffect() | ||
| } |
Comment on lines
10
to
12
| suspend fun signup(user: RequestUserEntity): Result<Response<BaseResponseWithoutDataDto>> | ||
| suspend fun login(user: RequestSignInEntity): Result<Response<BaseResponseWithoutDataDto>> | ||
| suspend fun changePassword(user: RequestChangePasswordEntity): Result<Response<BaseResponseWithoutDataDto>> |
There was a problem hiding this comment.
제가 실수로 이렇게 해서 따라한 것 같은데 Domain 모듈에서는 retrofit 종속성이 있으면 안됩니다!!
Response로 반환하면 안대용~
chattymin
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
이슈
다 고쳐볼라고 했는데 너무 늦어서 그냥 올렸습니다..
네비게이션도 고쳐볼라고 했지만 금요일까지 못 할 거 같아서 지금 피알 올렸습니다..
di, data, domain 부분을 수정해본다고 동민옵 코드를 보며 구현했으나 아직입니다......
그러니 signup 코드를 중점적으로 봐주시면 될 거 같습니다.