refactor/#9: init 사용

NOW-SOPT-ANDROID · May 10, 2024 · f92c796 · f92c796
1 parent d50abcc
commit f92c796
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/app/src/main/java/com/sopt/now/test/presentation/HomeFragment.kt b/app/src/main/java/com/sopt/now/test/presentation/HomeFragment.kt
@@ -40,8 +40,6 @@ class HomeFragment: Fragment() {
 
     // 사용자 프로필 설정
     private fun setUserProfile() {
-        userViewModel.userInfo()
-
         userViewModel.userInfoLiveData.observe(requireActivity()) { userInfo ->
             userInfo?.let {
                 val userProfile = Profile(
@@ -50,15 +48,12 @@ class HomeFragment: Fragment() {
                     userInfo = userInfo.data.phone,
                 )
                 userList.add(0, userProfile)
-                setRecyclerView()
             }
         }
     }
 
     // 친구 프로필 설정
     private fun setFriendProfile() {
-        friendViewModel.getFriendInfo(0)
-
         friendViewModel.friendInfoLiveData.observe(requireActivity()) { friendInfo ->
             friendInfo?.let {
                 friendInfo.data.forEach { friendData ->
@@ -67,7 +62,7 @@ class HomeFragment: Fragment() {
                         userName = friendData.firstName,
                         userInfo = friendData.email
                     )
-                    userList.add(friend)
+                    userList.add(1, friend)
                 }
                 setRecyclerView()
             }

diff --git a/app/src/main/java/com/sopt/now/test/presentation/HomeViewModel.kt b/app/src/main/java/com/sopt/now/test/presentation/HomeViewModel.kt
@@ -17,8 +17,12 @@ class HomeViewModel() : ViewModel() {
     val liveData = MutableLiveData<BaseState>()
     val friendInfoLiveData = MutableLiveData<ResponseFriendDto?>()
 
-    fun getFriendInfo(page: Int) {
-        friendService.getFriendInfo(page).enqueue(object : Callback<ResponseFriendDto> {
+    init{
+        friendInfo()
+    }
+
+    private fun friendInfo() {
+        friendService.getFriendInfo(0).enqueue(object : Callback<ResponseFriendDto> {
             override fun onResponse(
                 call: Call<ResponseFriendDto>,
                 response: Response<ResponseFriendDto>,
@@ -30,9 +34,7 @@ class HomeViewModel() : ViewModel() {
                         isSuccess = true,
                         message = response.message()
                     )
-                    Log.d("HomeViewModel", "Response: $data")
                 } else {
-                    Log.e("HomeViewModel", "Failed to get friend info: ${response.code()}")
                     val error = response.errorBody()?.string()
                     val gson = Gson()
                     try {

diff --git a/app/src/main/java/com/sopt/now/test/presentation/UserInfoViewModel.kt b/app/src/main/java/com/sopt/now/test/presentation/UserInfoViewModel.kt
@@ -1,6 +1,5 @@
 package com.sopt.now.test.presentation
 
-import android.util.Log
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.ViewModel
 import com.google.gson.Gson
@@ -21,7 +20,7 @@ class UserInfoViewModel : ViewModel() {
         userInfo()
     }
 
-    fun userInfo() {
+    private fun userInfo() {
         userService.getUserInfo().enqueue(object : Callback<ResponseUserInfoDto> {
             override fun onResponse(
                 call: Call<ResponseUserInfoDto>,