feat/#17: week7 xml 과제 구현 #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat/#13: week6 xml 과제 구현
…youjin-park into feat/week4_xml
boiledEgg-s
approved these changes
Jun 9, 2024
Comment on lines
+11
to
+19
| suspend fun postSignUp(requestSignUp: RequestSignUpDto): UiState<ResponseAuthDto> { | ||
| return withContext(Dispatchers.IO) { | ||
| runCatching { | ||
| ServicePool.authService.postSignUp(requestSignUp) | ||
| }.fold( | ||
| { UiState.Success(it) }, | ||
| { UiState.Failure(it.message.toString()) } | ||
| ) | ||
| } |
There was a problem hiding this comment.
이렇게 State를 정해서 뷰모델에 전달하는 방법도 있었네요!!
저장소와 상태관리 개념을 분리해야 할 것 같아서 저는 저장소에서 뷰모델에게 dto를 반환하도록 했는데 뭐가 올바른지 모르겠네요,,
지나가는 OB 있으면 답 좀 주시길,,
| authService.postLogin(request) | ||
| }.fold( | ||
| { response -> | ||
| val userId = response.headers()["location"] |
There was a problem hiding this comment.
이런 부분도 하드코딩 대신 상수화해서 사용하면 좋을 것 같아여!
hyeeum
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
UiState까지 사용하시는군요...역시... !!..! 저도 얼른 적용하겠습니다...
Comment on lines
+10
to
+20
| class UserProfileRepository { | ||
| suspend fun getUserProfile(): UiState<ResponseUserInfoDto> { | ||
| return withContext(Dispatchers.IO) { | ||
| runCatching { | ||
| ServicePool.userService.getUserInfo() | ||
| }.fold( | ||
| { UiState.Success(it) }, | ||
| { UiState.Failure(it.message.toString()) } | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
컴포즈 pr 에서도 말했지만 fold 새롭네요!
onSuccess와 onFailure를 명시할 필요가 없어 코드가 간결해졌군요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
KakaoTalk_20240508_163749744.mp4
To Reviewers 📢
week_4 브랜치가 안합쳐져서 뭐가 많네요..?
커밋 메시지 #17부터 보시면 됩니다!
⭐ 변경 사항 : Repository추가, ViewModel 수정 ⭐