feat/#19: week7 compose 과제 구현 #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat/#15: week6 compose 과제 구현
boiledEgg-s
approved these changes
Jun 9, 2024
hyeeum
approved these changes
Jun 9, 2024
| return withContext(Dispatchers.IO) { | ||
| runCatching { | ||
| authService.postLogin(request) | ||
| }.fold( |
There was a problem hiding this comment.
오 fold는 처음 보는데요? runCatching은 onSuccess/onFailure만 알고있었는데 이런 방법도 있군요!
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Composable | ||
| fun MainView(userId: String, userPw: String, userName: String, userDescription: String) { | ||
| fun MainView(viewModel: UserInfoViewModel) { |
| viewModel: SignUpViewModel, | ||
| context: Context, | ||
| userId: String, | ||
| userPw: String, |
There was a problem hiding this comment.
저두 pw 를 썼는데 축약어는 최대한 지양하는게 좋다고 말해주시더라구요..!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
KakaoTalk_20240508_163749744.mp4
To Reviewers 📢
week_4 브랜치가 안합쳐져서 뭐가 많습니다..
+일단 pr 올렸는데 오류 있어서 빨리 고치겠습니다..