Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docstrings #266

Merged
merged 11 commits into from
Jul 12, 2024
Merged

improve docstrings #266

merged 11 commits into from
Jul 12, 2024

Conversation

CunliangGeng
Copy link
Member

@CunliangGeng CunliangGeng commented Jul 10, 2024

Quite many small changes to the docstrings and docs to e.g.

  • add code examples
  • add link to specific function/class
  • add more explanation
  • display API doc better
    ...

Copy link
Member Author

CunliangGeng commented Jul 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CunliangGeng and the rest of your teammates on Graphite Graphite

@CunliangGeng CunliangGeng self-assigned this Jul 10, 2024
@CunliangGeng CunliangGeng marked this pull request as ready for review July 10, 2024 16:13
Base automatically changed from fix_tabular_file_header_detection to dev July 11, 2024 12:37

This class is used to arrange the datasets required by NPLinker according to the
configuration. The datasets include MIBiG, GNPS, antiSMASH, and BiG-SCAPE.
??? info "Concept and Diagram"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a syntax that mkdocs recognizes and links to "Concept and Diagram"?

Copy link
Member Author

@CunliangGeng CunliangGeng Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that syntax is not for link but for creating a info block (or callout), the effect looks like (you could see that on doc website)
image

>>> loader = DatasetLoader(config)
>>> loader.load()

See Also:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See Also:
See also:

Copy link
Member Author

@CunliangGeng CunliangGeng Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff requires that all section headers in a docstring should be capitalized and will automatically change also to Also. So let's use See Also:.

@gcroci2
Copy link
Contributor

gcroci2 commented Jul 11, 2024

Before merging, fix the trailing whitespace that makes format checking fail (src/nplinker/schemas/__init__.py:61:79: W291 Trailing whitespace) @CunliangGeng

Copy link
Member Author

CunliangGeng commented Jul 12, 2024

Merge activity

@CunliangGeng CunliangGeng merged commit e7efc8e into dev Jul 12, 2024
2 of 3 checks passed
@CunliangGeng CunliangGeng deleted the update_docs_docstrings branch July 12, 2024 08:50
Copy link

sonarcloud bot commented Jul 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants