Allow bigscape run for local mode #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CunliangGeng and the rest of your teammates on |
gcroci2
approved these changes
Sep 17, 2024
|
Tests are failing though @CunliangGeng: FAILED tests/unit/genomics/test_podp_antismash_downloader.py::test_genbank_id - ValueError: No antiSMASH data found for any genome
FAILED tests/unit/genomics/test_podp_antismash_downloader.py::test_jgi_id - ValueError: No antiSMASH data found for any genome
FAILED tests/unit/genomics/test_podp_antismash_downloader.py::test_genbank_jgi_id - ValueError: No antiSMASH data found for any genome |
Yes, it's a bit annoying to test online data, very easy to fail due to the change of the website. Let's ignore these failed tests at the moment, |
Merge activity
|
CunliangGeng
changed the base branch from
add_print_links
to
graphite-base/277
CunliangGeng
force-pushed
the
run_bigscape_local_mode
branch
from
974e84f
to
0d2bcf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the support of running bigscape in local mode when users does not provide bigscape data. If users provide data, then only validate it.