Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/ac power flow refactor #26

Merged
merged 26 commits into from
Oct 31, 2023
Merged

Jd/ac power flow refactor #26

merged 26 commits into from
Oct 31, 2023

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Oct 30, 2023

WIP refactoring the AC PowerFlow to support reactive power checks.

@jd-lara jd-lara self-assigned this Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #26 (57b5171) into main (e42dd74) will decrease coverage by 0.18%.
The diff coverage is 96.05%.

❗ Current head 57b5171 differs from pull request most recent head 932f83d. Consider uploading reports for the commit 932f83d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   89.65%   89.48%   -0.18%     
==========================================
  Files           7        9       +2     
  Lines         880      894      +14     
==========================================
+ Hits          789      800      +11     
- Misses         91       94       +3     
Flag Coverage Δ
unittests 89.48% <96.05%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/PowerFlowData.jl 96.03% <100.00%> (+0.16%) ⬆️
src/PowerFlows.jl 100.00% <ø> (ø)
src/common.jl 89.74% <100.00%> (ø)
src/nlsolve_ac_powerflow.jl 90.90% <100.00%> (-5.21%) ⬇️
src/powerflow_types.jl 100.00% <100.00%> (ø)
src/solve_dc_powerflow.jl 100.00% <ø> (ø)
src/ac_power_flow_jacobian.jl 98.97% <98.97%> (ø)
src/ac_power_flow.jl 91.35% <91.35%> (ø)

src/PowerFlowData.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@rodrigomha rodrigomha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

Remaining aspects is a test for the 14bus system with enforcing q limits, and updating the system if a bus change to PQ (from PV) if a Q limit is hit.

Once the tests are ready this looks good to merge.

@jd-lara jd-lara marked this pull request as ready for review October 31, 2023 00:37
@jd-lara jd-lara merged commit 1407950 into main Oct 31, 2023
2 of 5 checks passed
@jd-lara jd-lara deleted the jd/ac_power_flow_refactor branch October 31, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants