-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jd/ac power flow refactor #26
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 89.65% 89.48% -0.18%
==========================================
Files 7 9 +2
Lines 880 894 +14
==========================================
+ Hits 789 800 +11
- Misses 91 94 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
Remaining aspects is a test for the 14bus system with enforcing q limits, and updating the system if a bus change to PQ (from PV) if a Q limit is hit.
Once the tests are ready this looks good to merge.
WIP refactoring the AC PowerFlow to support reactive power checks.