Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jd/fix reduction indexing #1210

Merged
merged 10 commits into from
Jan 8, 2025
Merged

Jd/fix reduction indexing #1210

merged 10 commits into from
Jan 8, 2025

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jan 5, 2025

This PR add and error throw in cases where the user provides an external PTDF matrix with reduced branches and doesn't specify the option in the network model

@jd-lara jd-lara requested a review from daniel-thom January 5, 2025 20:23
Copy link
Contributor

github-actions bot commented Jan 5, 2025

Performance Results

Version Precompile Time
Main 4.130359424
This Branch 4.183276478
Version Build Time
Main-Build Time Precompile 67.055589
Main-Build Time Postcompile 0.987157664
This Branch-Build Time Precompile 67.540807748
This Branch-Build Time Postcompile 0.988865308
Version Build Time
Main-Solve Time Precompile 460.706950278
Main-Solve Time Postcompile 424.881551864
This Branch-Solve Time Precompile 1924.685989911
This Branch-Solve Time Postcompile 1881.23778164

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.32%. Comparing base (5772e25) to head (4e2dfae).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
src/core/network_model.jl 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1210      +/-   ##
==========================================
+ Coverage   77.24%   77.32%   +0.07%     
==========================================
  Files         121      121              
  Lines       13446    13458      +12     
==========================================
+ Hits        10387    10406      +19     
+ Misses       3059     3052       -7     
Flag Coverage Δ
unittests 77.32% <92.85%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...devices_models/devices/common/add_to_expression.jl 74.22% <100.00%> (+0.36%) ⬆️
src/core/network_model.jl 85.54% <50.00%> (-0.88%) ⬇️

... and 6 files with indirect coverage changes

@jd-lara jd-lara self-assigned this Jan 7, 2025
@jd-lara jd-lara merged commit f5b2a6d into main Jan 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants