Jp/add code autogen #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jerrypotts
commented
Jun 12, 2024
jerrypotts
commented
- Updated generate_structs.jl to be compatible with the JSON Schema file for Sienna Invest.
- Generated new structs based on a JSON Schema file for the simple capacity expansion model we are using for initial development.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/generate_structs.jl
Outdated
| struct_names = Vector{String}() | ||
| unique_accessor_functions = Set{String}() | ||
| unique_setter_functions = Set{String}() | ||
|
|
||
| for (struc_name, input) in data | ||
| for (struct_name, input) in data.data["\$defs"] | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
src/generate_structs.jl
Outdated
| item["closing_constructor_text"] = " where T <: $(item["parametric"])" | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
src/generate_structs.jl
Outdated
| accessor_name = accessor_module * "get_" * param["name"] | ||
| setter_name = accessor_module * "set_" * param["name"] * "!" | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
src/generate_structs.jl
Outdated
| # If all parameters have defaults then the positional constructor will | ||
| # collide with the kwarg constructor. | ||
| item["needs_positional_constructor"] = has_internal && has_non_default_values | ||
| item["needs_positional_constructor"] = item["has_internal"] && item["has_non_default_values"] |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| item["needs_positional_constructor"] = item["has_internal"] && item["has_non_default_values"] | |
| item["needs_positional_constructor"] = | |
| item["has_internal"] && item["has_non_default_values"] |
src/generate_structs.jl
Outdated
|
|
||
| filename = joinpath(directory, item["struct_name"] * ".jl") | ||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
src/generate_structs.jl
Outdated
| open(filename, "w") do io | ||
| write(io, strip(Mustache.render(IS.STRUCT_TEMPLATE, item))) | ||
| write(io, "\n") | ||
| push!(struct_names, item["struct_name"]) | ||
| end | ||
|
|
||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
src/generate_structs.jl
Outdated
| if print_results | ||
| println("Wrote $filename") | ||
| end | ||
| end | ||
|
|
||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
src/generate_structs.jl
Outdated
| @@ -144,6 +173,7 @@ | |||
| println("Wrote $filename") | |||
| end | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
rodrigomha
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
This is good. Let's merge to Jose's branch.
What do you think @jd-lara
jd-lara
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.