Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fields #17

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

Update Fields #17

wants to merge 54 commits into from

Conversation

rodrigomha
Copy link
Contributor

We need this merge to get the stuff working in PSIN.

#! format: off

"""
mutable struct ExistingTransportTechnology{T <: PSY.Device} <: Technology
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -30,29 +31,37 @@ This file is auto-generated. Do not edit.
om_costs_power::PSY.OperationalCost
balancing_topology::String
min_cap_energy::Float64
ext::Dict
region::Union{Nothing, Region, Vector{Region}}
initial_state_of_charge::Float64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operation data

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

ext::Dict
region::Union{Nothing, Region, Vector{Region}}
initial_state_of_charge::Float64
unit_size_energy::Float64
eff_up::Float64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use same as power systems and db

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated naming of these fields

eff_up::Float64
cluster::Int64
interest_rate::Float64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Financial

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to separate struct

cluster::Int64
interest_rate::Float64
ext::Dict
base_year::Int
reg_cost::Float64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operation too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@jerrypotts
Copy link
Contributor

Notes:

  • update naming conventions to use full words when possible. (min/max and up/dn are fine)
  • match names of fields to PowerSystems where possible

@NREL-Sienna NREL-Sienna deleted a comment from github-actions bot Jan 22, 2025
@NREL-Sienna NREL-Sienna deleted a comment from github-actions bot Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants