Add PSY base methods #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-lara
reviewed
Apr 8, 2024
scripts/portfolio_test.jl
Outdated
There was a problem hiding this comment.
Instead of making scripts. Write these as tests right away. We don't want to accumulate scripts in the main branch of the repo.
jd-lara
reviewed
Apr 11, 2024
src/supply.jl
Outdated
| @@ -5,8 +5,8 @@ struct SupplyTechnology{T <: PSY.Generator} <: Technology | |||
| fuel::PSY.ThermalFuels | |||
| prime_mover::PSY.PrimeMovers | |||
| capacity_factor::Float64 | |||
| capital_cost::IS.FunctionData | |||
| operational_cost::PSY.OperationalCost | |||
| capital_cost::Union{Nothing, IS.FunctionData} | |||
There was a problem hiding this comment.
we have appropriate null values for this now. Requires an IS merge.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+37
to
+38
| 1, 2, 3, # first investment period | ||
| 4, 5, 6 # second investment period |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| 1, 2, 3, # first investment period | |
| 4, 5, 6 # second investment period | |
| 1, | |
| 2, | |
| 3, # first investment period | |
| 4, | |
| 5, | |
| 6, # second investment period |
Comment on lines
+40
to
+43
| t_th_ext["investment_operational_periods_map"] = Dict( | ||
| 2030 => [1, 2, 3], | ||
| 2040 => [4, 5, 6], | ||
| ) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| t_th_ext["investment_operational_periods_map"] = Dict( | |
| 2030 => [1, 2, 3], | |
| 2040 => [4, 5, 6], | |
| ) | |
| t_th_ext["investment_operational_periods_map"] = Dict(2030 => [1, 2, 3], 2040 => [4, 5, 6]) |
| t_re_ext["capital_cost"] = 100.0 | ||
| t_re_ext["variable_capacity_factor"] = [0.8, 0.6, 0.3] | ||
|
|
||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| PSIP.add_technology!(p, t_th) | ||
| PSIP.add_technology!(p, t_re) | ||
|
|
||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO list: