Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thermal Rates and Thermal Load pages and compute module missing from Hybrid fuel cell host developer configurations #1903

Closed
sjanzou opened this issue Nov 8, 2024 · 0 comments · Fixed by #1911
Closed

Thermal Rates and Thermal Load pages and compute module missing from Hybrid fuel cell host developer configurations #1903

sjanzou opened this issue Nov 8, 2024 · 0 comments · Fixed by #1911
Assignees
@sjanzou @cpaulgilman
Labels
added to release notes PR and/or issue has been added to release notes for a public release bug
Milestone
SAM Fall 2024 Rel...

Comments

@sjanzou
Copy link
Collaborator

sjanzou commented Nov 8, 2024

The Hybrid host developer configurations should include Thermal Rates and Thermal Load page similarly to the Fuel Cell Commercial configuration
image

And the cmod_thermalrate compute module should be called after the cmod_utilityrate5 compute module is called
image

Currently, the hybrid fuel cell configurations do not include the Thermal Rates and Thermal Load page and do not call the thermalrate compute module:
image

image
@sjanzou sjanzou added the bug label Nov 8, 2024
sjanzou added a commit that referenced this issue Nov 15, 2024
@sjanzou
All updated api files for SAM #1903 and updated defaults and proforma
2528eb5
sjanzou added a commit that referenced this issue Nov 15, 2024
@sjanzou
Updated Windows defaults results for #1903
666e09f
@sjanzou sjanzou linked a pull request Nov 15, 2024 that will close this issue
Address SAM #1903 #1911
Merged
sjanzou added a commit that referenced this issue Nov 17, 2024
@sjanzou
Merge pull request #1911 from NREL/SAM_1903
3f5036d 
Address SAM #1903
@cpaulgilman cpaulgilman added this to the SAM Fall 2024 Release milestone Dec 10, 2024
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjanzou sjanzou

@cpaulgilman cpaulgilman

Labels
added to release notes PR and/or issue has been added to release notes for a public release bug
Projects
None yet
Milestone
SAM Fall 2024 Release
Development

Successfully merging a pull request may close this issue.

Address SAM #1903 NREL/SAM
2 participants
@sjanzou @cpaulgilman