Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address SAM #1903 #1911

Merged
merged 4 commits into from
Nov 17, 2024
Merged

Address SAM #1903 #1911

merged 4 commits into from
Nov 17, 2024

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Nov 15, 2024

Goes with NREL/ssc#1244

Please check proforma - added thermal value to Host returns and updated defaults.

Test file for testing with Fuel Cell Commercial and all Fuel Cell Hybrids with Host Developer

SAM_1903.zip

Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, and for adding thermal value rows to cash flow.

@sjanzou sjanzou merged commit 3f5036d into develop Nov 17, 2024
8 checks passed
@sjanzou sjanzou deleted the SAM_1903 branch November 17, 2024 08:40
@cpaulgilman cpaulgilman added this to the SAM Fall 2024 Release milestone Dec 10, 2024
@cpaulgilman cpaulgilman added bug added to release notes PR and/or issue has been added to release notes for a public release labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release bug
Projects
None yet
2 participants