Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate sizing functions that were causing ac sizing issues #1494

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Oct 10, 2023

Pull Request Template

Description

AC sizing issues were caused by the presence of two lk functions for battery sizing with AC or DC units. Remove one set of these functions to resolve the issue.

Fixes #1469

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: Calculated AC power is much closer to desired power for different battery configurations.

@brtietz brtietz merged commit 29befc5 into develop Oct 11, 2023
0 of 4 checks passed
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
@brtietz brtietz deleted the sam_1469_remove_duplicate_sizing_fcns branch December 13, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release battery bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AC battery sizing does not converge on the correct values
2 participants