Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable metering option from IPH commercial models. #1943

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

taylorbrown75
Copy link
Collaborator

@taylorbrown75 taylorbrown75 commented Dec 4, 2024

Description

Disabled metering option box on the electricity purchases page for IPH commercial models (trough and Fresnel).
Set default metering option to 'Buy all/ sell all' and added a UI equation check for IPH models. The IPH commercial models should now follow the same behavior as front of meter models.
Changed name of IPH commercial models 'Electricity Rates' page to 'Electricity Purchases'.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@taylorbrown75 taylorbrown75 added csp concentrating solar power UI User interface issue that applies across performance and financial models labels Dec 4, 2024
@taylorbrown75 taylorbrown75 added this to the SAM Fall 2024 Release milestone Dec 4, 2024
@taylorbrown75 taylorbrown75 requested a review from sjanzou December 4, 2024 23:00
@taylorbrown75 taylorbrown75 self-assigned this Dec 4, 2024
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented just like FOM electricity purchases - great UI work!

@@ -20079,7 +20079,7 @@
],
"ur_has_unused_items": 0.0,
"ur_is_default": 0.0,
"ur_metering_option": 0.0,
"ur_metering_option": 4.0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - Buy all / Sell all and allowing hourly/subhourly buy rates
image

@taylorbrown75 taylorbrown75 merged commit 9ca6539 into develop Dec 9, 2024
8 checks passed
@cpaulgilman cpaulgilman added the dev bug Internal bug that should not be included in release notes label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csp concentrating solar power dev bug Internal bug that should not be included in release notes UI User interface issue that applies across performance and financial models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove metering options from IPH commercial models on Electricity Rates page
3 participants