-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kva back to transformer #172
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to merge some of the other branches into master before we merge this one. The changes look good but there are some new modifications to the regulator writer in CYME (for instance) that should be merged first.
0e5b7e7
to
248552a
Compare
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 43.96% 43.94% -0.03%
==========================================
Files 74 74
Lines 16473 16383 -90
==========================================
- Hits 7243 7200 -43
+ Misses 9230 9183 -47
Continue to review full report at Codecov.
|
Attempt to address the KVA issues described in #160
@tarekelgindy, this PR impacts basically all parsers so we probably should be very careful and test it (smartd-ds and others) before eventually merging.
NOTES:
Gridlab-D
parsers and theEphasor
writer but I'm not familiar with them, so double checking seems like a good idea