Ssc 1058 ac loss accounting #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unsatisfactory unmet critical load. Requires philosophical discussion before proceeding - might make sense to feed back to dispatch current instead.
…c_loss_accounting
…ry to deliver sufficient power to load
dguittet
approved these changes
Oct 10, 2023
shared/lib_battery_powerflow.cpp
Outdated
| @@ -483,11 +489,8 @@ void BatteryPowerFlow::calculateACConnected() | |||
| P_fuelcell_to_grid_ac = 0; | |||
| } | |||
|
|
|||
| // Priliminary batt to grid for DC losses | |||
There was a problem hiding this comment.
this looks like a conjunction of prilliman and preliminary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve loss accounting for AC connected batteries. Powerflow code is now more aware of losses when calculating batt_to_load and can increase power to meet the load. Under the previous implementation x% of the power to each location was lost across the board, rather than accounting for the dynamics of whether the load or grid is served first.
Closes #1058. Test file and expected behavior is available in that issue. DC batteries were unaffected and pass the same new unit tests without changes.
This still treats the loss as a giant resistor in the AC system, which may not be what we want. Changing the definition of the battery availability losses will be handled in the future as a part of NREL/SAM#985