Sam 1208 revisit safety factor #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evisit_safety_factor
…evisit_safety_factor
…evisit_safety_factor
…evisit_safety_factor
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better account for round trip efficiency in the peak shaving dispatch calculations, removing the need for the safety factor. Update the tests accordingly.
Based on the test updates, it looks like there was an error in some of the inputs checks for custom dispatch for battwatts. This has been corrected.
Fixes NREL/SAM#1208
Pairs with SAM PR NREL/SAM#1512 to update test results for SAM.