Consistent monthly and annual energy labels #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `monthly_energy` "Monthly AC energy in Year 1" * `annual_energy` "Annual AC energy in Year 1" * Fix capitalization as convenient * Don't change labels for SWH, and for some CSP models that have long labels, or for Marine Energy, etc.
mjprilliman
approved these changes
Nov 5, 2024
| { SSC_OUTPUT, SSC_ARRAY, "monthly_energy", "Monthly energy", "kWh", "", "Monthly", "", "LENGTH=12", "" }, | ||
| { SSC_OUTPUT, SSC_MATRIX, "annual_energy_distribution_time","Annual energy production as function of Time", "", "", "Heatmaps", "", "", "" }, | ||
| { SSC_OUTPUT, SSC_ARRAY, "dc_monthly", "Monthly DC energy", "kWh", "", "Monthly", "", "LENGTH=12", "" }, | ||
| { SSC_OUTPUT, SSC_ARRAY, "ac_monthly", "Monthly AC energy", "kWh", "", "Monthly", "", "LENGTH=12", "" }, |
There was a problem hiding this comment.
This is probably for a different issue, but I believe ac_monthly and monthly_energy will always be the same. Do we need both?
There was a problem hiding this comment.
This is probably for a different issue, but I believe ac_monthly and monthly_energy will always be the same. Do we need both?
This is probably a vestige of the original implementation of PVWatts. I don't think we need both in SAM, but removing ac_monthly may break code out there in PySAM or other apps that call the PVWatts library.
cpaulgilman
added a commit
to NREL/SAM
that referenced
this pull request
Dec 7, 2024
Grid limits do not affect electricity imports from the grid. Revise IPH molten salt linear Fresnel topics Power tower heliostast pivot point height definition. New Financial Parameters topic for LCOH Calculator. Wind wake loss inputs NREL/ssc#1186 Annual energy and monthly energy label updates: NREL/ssc#1236 Replace parentheses with commas for installation cost units Battery availability loss. NREL/ssc#1241 Tidal Energy Converter page revisions for new options, see #1807. New net billing with carryover options. NREL/ssc#1200 IPH MSLF revisions: #1444 Fix fuel cell model link https://www.nrel.gov/hydrogen/fuel-cell-power-model.html, replace with https://www.nrel.gov/docs/fy13osti/57457.pdf. PV GCR affects output for bifacial modules. Revise report generator topic to explain template not available for some configurations. Add topics for IPH financial models Generic system to custom generatio profile Standalone battery time step New autographs and default graphs for battery configurations: #1884 System Availability three hour option for marine, "hourly" to "time series" ## October 24, 2024 Update Cambium note about years for Cambium 2023 Battery dispatch (BTM and FOM) battery can charge from grid-limited system power Grid limits battery can charge from grid-limited system power Project with 100% debt results in IRR = NaN Revise real discount rate description Geothermal system availability losses Revise metrics topics to facilitate navigation. Revise weather file format to include CSV for wind Revise PV subhourly clipping "Allen method" Revise Cost of Acquiring Financing.
15 tasks
cpaulgilman
added a commit
to NREL/SAM
that referenced
this pull request
Dec 10, 2024
* Help revisions for SAM 2024.12.12 Grid limits do not affect electricity imports from the grid. Revise IPH molten salt linear Fresnel topics Power tower heliostast pivot point height definition. New Financial Parameters topic for LCOH Calculator. Wind wake loss inputs NREL/ssc#1186 Annual energy and monthly energy label updates: NREL/ssc#1236 Replace parentheses with commas for installation cost units Battery availability loss. NREL/ssc#1241 Tidal Energy Converter page revisions for new options, see #1807. New net billing with carryover options. NREL/ssc#1200 IPH MSLF revisions: #1444 Fix fuel cell model link https://www.nrel.gov/hydrogen/fuel-cell-power-model.html, replace with https://www.nrel.gov/docs/fy13osti/57457.pdf. PV GCR affects output for bifacial modules. Revise report generator topic to explain template not available for some configurations. Add topics for IPH financial models Generic system to custom generatio profile Standalone battery time step New autographs and default graphs for battery configurations: #1884 System Availability three hour option for marine, "hourly" to "time series" ## October 24, 2024 Update Cambium note about years for Cambium 2023 Battery dispatch (BTM and FOM) battery can charge from grid-limited system power Grid limits battery can charge from grid-limited system power Project with 100% debt results in IRR = NaN Revise real discount rate description Geothermal system availability losses Revise metrics topics to facilitate navigation. Revise weather file format to include CSV for wind Revise PV subhourly clipping "Allen method" Revise Cost of Acquiring Financing. * Help revisions Revise "receiver startup delay time" and "receiver startup delay energy fraction" descriptions for trough and Fresnel models. Fix remaining references to "generic system" model. --------- Co-authored-by: Steven Janzou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NREL/SAM#1876
Use following labels as much as possible
monthly_energy"Monthly energy in Year 1"annual_energy"Annual energy in Year 1"