Battery cycle-calendar life model updated to use sum not min

[dguittet]

I modified the cycle calendar model to take the sum instead of the min. Here are the results of 25-yr battery capacity percent (replacements are off) across the different chemistries and models. Overall, there are 6675 cycles. Average DOD is ~50%

The table models have more degradation now.

However, whereas in the Old column, the NMC/Gr table and algebraic model both had more degradation than LFP, in the New version, the LFP table has less degradation than NMC/Gr Alg. The LMO/LTO table doesn’t change because the calendar loss is 0.

This is fine because the calendar-cycle models aren’t comparable to the algebraic ones—apples and oranges.

Model	Value	Old	New
NMC/Gr Alg	25-yr cap %	76.0021	76.0021
NMC/Gr Table	25-yr cap %	65.4057	47.6304
LFP/Gr Table	25-yr cap %	82.2394	65.8467
LMO/LTO Alg	25-yr cap %	92.9983	92.9983
LMO/LTO Table	25-yr cap %	89.7067	89.7067

 

[dguittet]

@brtietz The tests are failing because the error between Old Mac/Linux/Windows vs New Mac is greater than the abs tolerance of 0.01 for some of the battery tests. Mind if I increase the tol for this particular test? runTestCycleAt3C

[brtietz]

@brtietz The tests are failing because the error between Old Mac/Linux/Windows vs New Mac is greater than the abs tolerance of 0.01 for some of the battery tests. Mind if I increase the tol for this particular test? runTestCycleAt3C

Increasing the tol seems good to me. Maybe 0.1?

[dguittet]

@brtietz The tests are failing because the error between Old Mac/Linux/Windows vs New Mac is greater than the abs tolerance of 0.01 for some of the battery tests. Mind if I increase the tol for this particular test? runTestCycleAt3C

Increasing the tol seems good to me. Maybe 0.1?

Yep. Tests are passing now

[brtietz]

Results look good, tests all change in the direction that we expected. Do we need to feed any of this back to Kandler and Paul?

[dguittet]

Results look good, tests all change in the direction that we expected. Do we need to feed any of this back to Kandler and Paul?

I don't think it's necessary