Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address SAM issue 1903 (add Thermal Rates and Thermal Load to Hybrid Host Developer configurations #1244

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Address SAM issue 1903 (add Thermal Rates and Thermal Load to Hybrid Host Developer configurations #1244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a95a943
PVWatts-Wind-FuelCell / Host Developer running with Thermal Rates and…
sjanzou Nov 13, 2024
b241d0e
Merge branch 'develop' into SAM_1903
sjanzou Nov 15, 2024
7e52c1b
Update host developer to account for thermal savings for SAM #1903
sjanzou Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions ssc/cmod_host_developer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ static var_info _cm_vtab_host_developer[] = {

{ SSC_INPUT, SSC_ARRAY, "utility_bill_w_sys", "Electricity bill for system", "$", "", "Charges by Month", "*", "", "" },
{ SSC_INPUT, SSC_MATRIX, "charge_w_sys_dc_tou_ym", "Demand charge with system (TOU)", "$", "", "Charges by Month", "*", "", "COL_LABEL=MONTHS,FORMAT_SPEC=CURRENCY,GROUP=UR_AM" },
{ SSC_INPUT, SSC_ARRAY, "annual_energy_value", "Energy value", "$", "", "System Output", "*", "", "" },
{ SSC_INPUT, SSC_ARRAY, "annual_thermal_value", "Energy value", "$", "", "System Output", "", "", "" },
// { SSC_INPUT, SSC_ARRAY, "annual_energy_value", "Energy value", "$", "", "System Output", "*", "", "" },
{ SSC_INPUT, SSC_ARRAY, "annual_thermal_value", "Host thermal value", "$", "", "System Output", "", "", "" },
{ SSC_INPUT, SSC_ARRAY, "gen", "Power generated by renewable resource", "kW", "", "System Output", "*", "", "" },

// { SSC_OUTPUT, SSC_ARRAY, "gen_purchases", "Electricity from grid", "kW", "", "System Output", "", "", "" },
Expand Down Expand Up @@ -852,6 +852,7 @@ enum {
CF_cumulative_payback_with_expenses,
CF_nte,
CF_host_energy_value,
CF_host_thermal_value,



Expand Down Expand Up @@ -1017,6 +1018,8 @@ class cm_host_developer : public compute_module
double om_opt_fuel_1_usage = as_double("om_opt_fuel_1_usage");
double om_opt_fuel_2_usage = as_double("om_opt_fuel_2_usage");



// additional o and m sub types (e.g. batteries and fuel cells)
int add_om_num_types = as_integer("add_om_num_types");
ssc_number_t nameplate1 = 0;
Expand Down Expand Up @@ -2822,7 +2825,16 @@ class cm_host_developer : public compute_module

// ----------------------------------------------------------------------------
// Host calculations based on thirdpartyownership with PPA agreement

if (is_assigned("annual_thermal_value")) {
arrp = as_array("annual_thermal_value", &count);
if ((int)count != nyears + 1)
throw exec_error("host developer", util::format("thermal value input wrong length (%d) shouCF_host_energy_valueld be (%d)", count, nyears + 1));
i = 0;
while (i < nyears && i < (int)count) {
cf.at(CF_host_thermal_value, i + 1) = (double)arrp[i + 1];
i++;
}
}
// output from utility rate already nyears+1 - no offset
arrp = as_array("annual_energy_value", &count);
if ((int)count != nyears + 1)
Expand All @@ -2840,7 +2852,7 @@ class cm_host_developer : public compute_module

cf.at(CF_after_tax_cash_flow, i) =
cf.at(CF_after_tax_net_equity_cost_flow, i)
+ cf.at(CF_host_energy_value, i);
+ cf.at(CF_host_energy_value, i) + cf.at(CF_host_thermal_value, i);

cf.at(CF_payback_with_expenses, i) =
cf.at(CF_after_tax_cash_flow, i);
Expand Down Expand Up @@ -3346,8 +3358,8 @@ class cm_host_developer : public compute_module
save_cf( CF_debt_payment_principal, nyears, "cf_debt_payment_principal" );
save_cf( CF_debt_balance, nyears, "cf_debt_balance" );

save_cf( CF_energy_value, nyears, "cf_energy_value" );
save_cf( CF_ppa_price, nyears, "cf_ppa_price" );
save_cf(CF_energy_value, nyears, "cf_energy_value");
save_cf( CF_ppa_price, nyears, "cf_ppa_price" );
save_cf( CF_om_fixed_expense, nyears, "cf_om_fixed_expense" );
save_cf( CF_om_production_expense, nyears, "cf_om_production_expense" );
save_cf( CF_om_capacity_expense, nyears, "cf_om_capacity_expense" );
Expand Down
18 changes: 17 additions & 1 deletion ssc/cmod_hybrid.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,6 @@ class cm_hybrid : public compute_module
prepend_to_output((var_table*)compute_module_outputs, "annual_fuel_usage_lifetime", arr_length, yr_0_value);
prepend_to_output((var_table*)compute_module_outputs, "fuelcell_annual_energy_discharged", arr_length, yr_0_value);


ssc_data_set_table(outputs, compute_module.c_str(), compute_module_outputs);
ssc_module_free(module);
ssc_data_free(compute_module_outputs);
Expand Down Expand Up @@ -591,9 +590,23 @@ class cm_hybrid : public compute_module
pHybridOMSum[y] += om_landlease[y];
}
}

ssc_number_t* pThermalPower = ((var_table*)outputs)->allocate("fuelcell_power_thermal", genLength);
size_t thermalPowerLen = 0;


for (size_t f = 0; f < fuelcells.size(); f++) {
var_table fuelcell_outputs = ((var_table*)outputs)->lookup(fuelcells[f])->table;
size_t count_fc;
ssc_number_t* fc_thermalpower = fuelcell_outputs.as_array("fuelcell_power_thermal", &thermalPowerLen);
if(thermalPowerLen != genLength) {
throw exec_error("hybrid", util::format("fuel cell power thermal size (%d) incorrect", (int)thermalPowerLen));
}
else {
for (size_t i = 0; i < genLength; i++)
pThermalPower[i] = fc_thermalpower[i];
}

ssc_number_t* om_production = fuelcell_outputs.as_array("cf_om_production", &count_fc);
ssc_number_t* om_fixed = fuelcell_outputs.as_array("cf_om_fixed", &count_fc);
ssc_number_t* om_capacity = fuelcell_outputs.as_array("cf_om_capacity", &count_fc);
Expand Down Expand Up @@ -631,6 +644,9 @@ class cm_hybrid : public compute_module
if (batteries.size() > 0)
ssc_data_set_number(static_cast<ssc_data_t>(&input), "is_hybrid", 1); // for updating battery outputs to annual length in update_battery_outputs in common_financial.cpp

if (fuelcells.size() > 0)
ssc_data_set_array(static_cast<ssc_data_t>(&input), "fuelcell_power_thermal", pThermalPower, (int)thermalPowerLen); // for running cmod_thermalrate

ssc_data_set_number(static_cast<ssc_data_t>(&input), "system_use_lifetime_output", 1);

// set additional inputs from previous results - note - remove these from UI?
Expand Down
8 changes: 5 additions & 3 deletions ssc/cmod_thermalrate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,11 @@ static var_info vtab_thermal_rate[] = {
{ SSC_OUTPUT, SSC_ARRAY, "annual_thermal_value", "Thermal value", "$", "", "Annual", "*", "", "" },
// { SSC_OUTPUT, SSC_ARRAY, "annual_thermal_revenue_with_system", "Thermal value with system", "$", "", "Annual", "*", "", "" },
// { SSC_OUTPUT, SSC_ARRAY, "annual_thermal_revenue_without_system", "Thermal value without system", "$", "", "Annual", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "thermal_revenue_with_system", "Thermal revenue with system", "$", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "thermal_revenue_without_system", "Thermal revenue without system", "$", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_NUMBER, "thermal_load_year1", "Thermal load (year 1)", "$", "", "", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "thermal_revenue_with_system", "Thermal revenue with system", "$", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "thermal_revenue_without_system", "Thermal revenue without system", "$", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "thermal_cost_with_system", "Thermal cost with system", "$", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_ARRAY, "thermal_cost_without_system", "Thermal cost without system", "$", "", "Time Series", "*", "", "" },
{ SSC_OUTPUT, SSC_NUMBER, "thermal_load_year1", "Thermal load (year 1)", "$", "", "", "*", "", "" },
{ SSC_OUTPUT, SSC_NUMBER, "thermal_savings_year1", "Thermal savings (year 1)", "$", "", "", "*", "", "" },
{ SSC_OUTPUT, SSC_NUMBER, "thermal_cost_with_system_year1", "Thermal cost with sytem (year 1)", "$", "", "", "*", "", "" },
{ SSC_OUTPUT, SSC_NUMBER, "thermal_cost_without_system_year1", "Thermal cost without system (year 1)", "$", "", "", "*", "", "" },
Expand Down