Fixes to work with collection-2021* conda envs #18
Conversation
| # UserWarning: Couldn't start log: Log file is already active: | ||
| # /home/xf03id/logs/ophyd_user_log_xf03id.log |
There was a problem hiding this comment.
@jklynch, this is the IPython logging issue we've observed today.
There was a problem hiding this comment.
Maybe it is this line from ipython_ophyd/profile_collection/ipython_config.py:
# Start logging to the given file in append mode.
c.TerminalInteractiveShell.logappend = '/home/xf03id/logs/ophyd_user_log_xf03id.log'There was a problem hiding this comment.
You could remove that line from ipython_config.py and specify that file with BLUESKY_IPYTHON_LOG_FILE.
There was a problem hiding this comment.
Indeed! Not sure why I wasn't able to find it with git grep... probably I was in the startup/ directory that time.
That's the place in the code:
https://github.com/NSLS-II-HXN/ipython_ophyd/blob/d59ecd4799f4d212525aca1e1956cc989405bb48/profile_collection/ipython_config.py#L297-L298
mrakitin
force-pushed
the
deploy-2020-2
branch
2 times, most recently
from
dcd4a6c
to
8502195
Compare
mrakitin
changed the title
startup/00-startup.py
Outdated
| kafka_publisher = Publisher( | ||
| topic="hxn.bluesky.datum.documents", | ||
| bootstrap_servers=os.environ['BLUESKY_KAFKA_BOOTSTRAP_SERVERS'], | ||
| bootstrap_servers=os.getenv("BLUESKY_KAFKA_BOOTSTRAP_SERVERS", ""), |
There was a problem hiding this comment.
I don't think that you want to make this change because this environment variable is mandatory.
There was a problem hiding this comment.
I'd like to keep in mind that the code should also be testable in the cloud. Any idea how to test it in the CI?
There was a problem hiding this comment.
OK, #22 should resolve that. Please review.
mrakitin
changed the title
|
This PR should not be merged yet, because more work must be done before the new environment can be used at the beamline. Converting to draft. |
|
CI fails because |
|
I manually added changes from #22 to avoid long rebase. |
|
This fails CI but it is what the beamline is actually running on. Merging. |
These fixed made the startup files to start successfully against the
collection-2020-2.0rc8conda env. Done with @dmgav during today's deployment visit at HXN.xref #17 and NSLS-II-HXN/hxnfly#3 and the latest tag of https://github.com/NSLS-II-HXN/hxntools.
Requires:
nslsiihxnfly#8