Tiled compatibility #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the wacky `xas/scratch.py` file * Use `pipreqs` to generate a usable `requirements.txt` file (note that the pyqt package was not installable, it appears that the package itself is broken, note the commented out line in the requirements). * Remove the unused `requirements-dev.txt` file.
Add dummy file `get_df_and_metadata_from_db` which needs to be implememented as a hook for lightway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@elistavitski I will be using this PR as a WIP to make the changes I'll need to in order to get things working. So far I have made the following possibly breaking changes.
scratch.pyfile. No idea what that's about but it was breaking my linters/formatters and didn't look usable.requirements.txtfile. note thatPyQt5==5.15.9appears to be broken and I'm not sure why. I've removed it from the requirements for now. We might have to figure out a way around this or a way to install this successfully if any of your code really depends on it.requirements-dev.txt.blackon every file. The formatting before this was just unreadable.