Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress on NYX on 2021-12-03 #15

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Progress on NYX on 2021-12-03 #15

wants to merge 5 commits into from

Conversation

mrakitin
Copy link
Member

@mrakitin mrakitin commented Dec 3, 2021

@JunAishima JunAishima marked this pull request as ready for review December 16, 2021 22:13
mrakitin
mrakitin commented Dec 17, 2021
View reviewed changes
Copy link
Member Author

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few updates to clean it per @RobertSchaffer1's suggestions.

startup/50-objects.py Outdated Show resolved Hide resolved
startup/50-objects.py Show resolved Hide resolved
@JunAishima JunAishima mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertSchaffer1 RobertSchaffer1 RobertSchaffer1 left review comments

@JunAishima JunAishima Awaiting requested review from JunAishima

@mskinner5278 mskinner5278 Awaiting requested review from mskinner5278

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrakitin @RobertSchaffer1 @JunAishima