-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ae sample quality #7
base: main
Are you sure you want to change the base?
Conversation
except NoRecommendation: | ||
queue_server.queue_item_add(None) | ||
else: | ||
response = queue_server.queue_item_add( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pdf_count
plan will do both the move and the count (and get the meta-data right).
@@ -37,10 +41,21 @@ def callback(name, doc): | |||
try: | |||
next_point = adaptive_object.ask(1) | |||
except NoRecommendation: | |||
queue.put(None) | |||
queue_server.queue_item_add(None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add None
to the queueserver. If this is a case where you don't know which sample to measure and want to wait for a future recommendation just pass
and tell the queueserver nothing. But maybe you do have a fallback you can do here when no recommendation is made.
Add basic functionality for adaptive experiments based on quality with queue server. There are a handful of TODOs lingering.