Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ae sample quality #7

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Ae sample quality #7

wants to merge 7 commits into from

Conversation

maffettone
Copy link
Contributor

@maffettone maffettone commented Dec 3, 2021

Add basic functionality for adaptive experiments based on quality with queue server. There are a handful of TODOs lingering.

  1. Add sensible default args for mv and count plans
  2. Validate the assumptions on documents in the index_reccomender_factory callback.
  3. Update default zmq server arguments
  4. Add any start or clearing of the queue necessary in the plan script.

except NoRecommendation:
queue_server.queue_item_add(None)
else:
response = queue_server.queue_item_add(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pdf_count plan will do both the move and the count (and get the meta-data right).

@@ -37,10 +41,21 @@ def callback(name, doc):
try:
next_point = adaptive_object.ask(1)
except NoRecommendation:
queue.put(None)
queue_server.queue_item_add(None)
Copy link

@jklynch jklynch Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add None to the queueserver. If this is a case where you don't know which sample to measure and want to wait for a future recommendation just pass and tell the queueserver nothing. But maybe you do have a fallback you can do here when no recommendation is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants