String/Char caproto IOC with demo tests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t`, `cainfo`, etc.)
* replaces unsupport characters with underscores _ * github artifact upload does not support the special chars: - Double quote " - Colon : - Less than < - Greater than > - Vertical bar | - Asterisk * - Question mark ? - Carriage return \r - Line feed \n * note that \r, \n are included in whitespace regex symbol \s
Tests are passing after adding a regex based sanitizer to replace all unsupported chars in file path. But I had to update the test file as well (to use the same sanitizer for when creating the write dir). |
|
Thanks for your commits, @hyperrealist! They look great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates how
caproto/pyepics/caputdeal with string/char PVs defined via different options in caproto.The test with
%csucceeds now after replacing the blank spaces with_, however, it has:as time separators, so the GH artifact uploading step fails:I think we should also fix the colons from being in the file names.