Sensor failure recovery, support calibration to the antenna, save onboard cals separately, cal on startup #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now handle sensor and differential calibrations
and pass loaded actions dictionary to constructor
…if not set and no calibration provided.
…m settings since it is used in scos-actions.
…on/__init__.py to ensure healthy signal analyzer.
"running_tests" case is covered since MOCK_SIGAN is always true when running tests
jhazentia
reviewed
Mar 28, 2024
jhazentia
reviewed
Mar 28, 2024
jhazentia
reviewed
Mar 28, 2024
jhazentia
reviewed
Mar 28, 2024
jhazentia
requested changes
Mar 28, 2024
jhazentia
reviewed
Mar 28, 2024
jhazentia
reviewed
Mar 28, 2024
No longer make this function arbitrarily distinguish between "onboard" and "sensor" calibrations
remove preamp_enable and attenuation cal parameters from example JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores scos-sensor's ability to restart and recover from severe failures. In addition, support is added for a differential calibration file to allow for additional loss to move the reference point to the antenna. Onboard calibrations are modified to save to an onboard calibration file and the initial sensor calibration file is never altered to protect it from being corrupted during a shutdown or failure. Finally, settings are added to enable calibrations to optionally be performed on startup if the any calibrations occurred beyond a configurable amount of time in the past. Note: this will need requirements updating when scos-actions and scos-tekrsa PRs are merged.