-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Docker Compose configuration entirely with environment variables #282
Draft
aromanielloNTIA
wants to merge
22
commits into
master
Choose a base branch
from
all-config-with-env
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #279 by adding new environment variables
SSD_DEVICE
andAPI_SHM_SIZE
.Now,
SSD_DEVICE
is used to map the/dev/nvme0n1
device in the API container, which is used by the SEA edge compute action to get diagnostic SSD SMART data. The default value is dynamically retrieved using the commandlsblk -I 8 -npdo KNAME
which should work in most cases, and resolves to/dev/nvme0n1
for SEA sensors. This default could cause missing metadata when using the SEA action if theSSD_DEVICE
is not an SSD. The default setting will also cause SCOS Sensor to fail to start if multiple devices are returned bylsblk -I 8 -npdo KNAME
.API_SHM_SIZE
is used to set the shared memory in the API container, and a default is provided keeping it at 16 GB. This is used to provide sufficient shared memory to the Ray package for parallel processing of large IQ captures.