Sea 178 test actions loading #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge scos-actions branch
…78_test_actions_loading
…78_test_actions_loading
…78_test_actions_loading
…n running tests, remove cal adjust from cbrs measure yml files
dboulware
approved these changes
May 6, 2024
src/scos_tekrsa/discover/__init__.py
Outdated
| @@ -32,6 +33,21 @@ | |||
| logger.debug("Created Monitor SIGAN action") | |||
| # Pass new radio to existing action classes with new SDR specific yaml files | |||
| logger.debug("Initializing yaml actions") | |||
| yaml_actions, yaml_test_actions = init(yaml_dir=ACTION_DEFINITIONS_DIR) | |||
| yaml_actions, _ = init(yaml_dir=ACTION_DEFINITIONS_DIR) | |||
There was a problem hiding this comment.
I think this needs a similar check as done below to only load these actions if the SIGAN_MODULE and SIGAN_CLASS are tekrsa.
| duration_ms: 714 | ||
| nskip: 0 | ||
| classification: UNCLASSIFIED | ||
| calibration_adjust: False |
There was a problem hiding this comment.
I think if you add an rf_path: antenna parameter it will allow this action to work on sensors that have a configurable preselector and sensors that have no preselector. Currently, it errors when the sensor has a configurable preselector.
| nffts: 300 | ||
| nskip: 0 | ||
| classification: UNCLASSIFIED | ||
| calibration_adjust: False |
There was a problem hiding this comment.
Add rf_path param as in IQ action comment.
| - 10000 | ||
| nskip: 0 | ||
| classification: UNCLASSIFIED | ||
| calibration_adjust: False |
There was a problem hiding this comment.
add rf_path param. See single action IQ yml comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.