Handle Eval-STIG style XCCDF #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion; trigger resultEngine processing in non-scap mode for either evaluate-stig or stig-manager products
…turn accommodating STIG Viewer's expected format which only expects one <message> block. <message> will have the separate detail and comment fields concatenated together if answer file was used. The content of what would have been a separate comment field is included in the sm:overrides.remark element, so it is removed from the tail end of detail if present.
csmig
requested changes
Oct 29, 2024
csmig
approved these changes
Oct 31, 2024
cd-rite
changed the title
cd-rite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses XCCDF ruleResult
<message>text, if present, to populate "review.detail" for all XCCDF (SCC tool now puts notes in this block as well).Eval STIG concatenates detail (eval-stig default result) and comment (answer file result if present) into message. for STIG Viewer compatibility.
Eval STIG generates
<sm:resultEngine>block with STIGMan-style XCCDF output, but if answer file adjusted answer, populates<override><remark>with the standard "comment" as well.This lets us populate review.comment if applicable and strip out the duplicated comment text from the detail text.
Also adjusts cpe regex to handle both cpe expression styles- Resolves: #27