This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Stop simulators when there are no clients #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrendanAnnable
commented
Sep 19, 2018
| } | ||
| }, | ||
| { fireImmediately: true }, | ||
| ) |
There was a problem hiding this comment.
- Remove duplication between
prod.tsanddev.ts
| } | ||
| }, | ||
| { fireImmediately: true }, | ||
| ) |
There was a problem hiding this comment.
Uglier than needed I suspect. Perhaps VirtualRobots should instead expose a more flexible API that would be more suitable for reacting to an observable value.
Something like:
reaction(() => {
() => now(frequency) && numConections > 0,
enabled => enabled && virtualRobots.tick(),
{ fireImmediately: true },
})Will try this later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops my CPU from spinning while webpack is running but I have nothing open in the browser.