Skip to content

Commit

Permalink
Allow multi-GPU tests and enable MPS (#1153)
Browse files Browse the repository at this point in the history
- CI ran in 15m50s with this change (more tests), vs. 18m before
  • Loading branch information
olupton authored Nov 23, 2024
1 parent b4d8558 commit b0e6753
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/container/test-jax.sh
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ for t in $*; do
done

TEST_TAG_FILTER_ARRAY=()
TEST_TAG_FILTER_ARRAY+=('-multiaccelerator')

COMMON_FLAGS=$(cat << EOF
--@local_config_cuda//:enable_cuda
--cache_test_results=${CACHE_TEST_RESULTS}
Expand Down Expand Up @@ -163,7 +161,10 @@ case "${BATTERY}" in
;;
esac

TEST_TAG_FILTERS=$(IFS=, ; echo "--test_tag_filters=${TEST_TAG_FILTER_ARRAY[*]}")
TEST_TAG_FILTERS=""
if [[ ${#TEST_TAG_FILTER_ARRAY[@]} > 0 ]]; then
TEST_TAG_FILTERS=$(IFS=, ; echo "--test_tag_filters=${TEST_TAG_FILTER_ARRAY[*]}")
fi

print_var NCPUS
print_var NGPUS
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,7 @@ jobs:
docker run -i --shm-size=1g --gpus all \
${{ needs.build-jax.outputs.DOCKER_TAG_FINAL }} \
bash <<"EOF" |& tee tee test-gpu.log
nvidia-cuda-mps-control -d
test-jax.sh -b gpu
EOF
STATISTICS_SCRIPT: |
Expand Down

0 comments on commit b0e6753

Please sign in to comment.