Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken NeMo dependencies #372

Merged
merged 16 commits into from
Nov 15, 2024
Merged

Fix broken NeMo dependencies #372

Changes from 4 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2514aab
add packaging
sarahyurick Nov 14, 2024
7e147ed
move to requires
sarahyurick Nov 14, 2024
320a1b4
move to github ci file
sarahyurick Nov 14, 2024
d232be4
add pin
sarahyurick Nov 14, 2024
9089871
add torch
sarahyurick Nov 15, 2024
763128b
add suggestion from mamba readme
sarahyurick Nov 15, 2024
2387636
try github install
sarahyurick Nov 15, 2024
81024d9
add comma
sarahyurick Nov 15, 2024
c827d95
another attempt
sarahyurick Nov 15, 2024
c1311d6
remove nemo toolkit
sarahyurick Nov 15, 2024
ad10ab2
add datasets
sarahyurick Nov 15, 2024
4e3fd8f
try removing cython
sarahyurick Nov 15, 2024
87997e4
remove cython
sarahyurick Nov 15, 2024
45f2a44
sentencepiece
sarahyurick Nov 15, 2024
3f20ecb
run black
sarahyurick Nov 15, 2024
959b6b4
apply ryan's suggestion
sarahyurick Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ dependencies = [
"lxml_html_clean",
"mecab-python3",
"mwparserfromhell==0.6.5",
"nemo_toolkit[nlp]>=1.23.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #376.

# TODO: Pin until dependencies from https://github.com/NVIDIA/NeMo?tab=readme-ov-file#install-nemo-framework are updated
"nemo_toolkit[nlp]<2.0.0",
"numpy<2",
"openai",
"peft",
Expand Down