Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove max_text_bytes_per_part #385

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Remove max_text_bytes_per_part #385

wants to merge 7 commits into from
+5 −259

Conversation

sarahyurick
Copy link
Collaborator

Closes #331.

@sarahyurick
remove functions
44c55d2 
Signed-off-by: Sarah Yurick <[email protected]>
@sarahyurick
run black
66f4d1e 
Signed-off-by: Sarah Yurick <[email protected]>
@sarahyurick sarahyurick added the gpuci Run GPU CI/CD on PR label Nov 20, 2024
VibhuJawa
VibhuJawa requested changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this. We should remove max_text_bytes_per_part cleanly and retire all of string functionality.

nemo_curator/modules/fuzzy_dedup.py Outdated Show resolved Hide resolved
nemo_curator/modules/fuzzy_dedup.py Outdated Show resolved Hide resolved
nemo_curator/modules/fuzzy_dedup.py Outdated Show resolved Hide resolved
nemo_curator/utils/fuzzy_dedup_utils/output_map_utils.py Outdated Show resolved Hide resolved
@sarahyurick
apply vibhu's review
a9362dc 
Signed-off-by: Sarah Yurick <[email protected]>
@sarahyurick
run black
96eae26 
Signed-off-by: Sarah Yurick <[email protected]>
@sarahyurick sarahyurick added gpuci Run GPU CI/CD on PR and removed gpuci Run GPU CI/CD on PR labels Nov 22, 2024
@sarahyurick sarahyurick added gpuci Run GPU CI/CD on PR and removed gpuci Run GPU CI/CD on PR labels Dec 23, 2024
@sarahyurick sarahyurick added gpuci Run GPU CI/CD on PR and removed gpuci Run GPU CI/CD on PR labels Jan 18, 2025
@sarahyurick sarahyurick marked this pull request as draft January 23, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VibhuJawa VibhuJawa VibhuJawa requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
gpuci Run GPU CI/CD on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate max_text_bytes_per_part
2 participants
@sarahyurick @VibhuJawa